[alsa-devel] [PATCH 4/4] ASoC: TWL4030: Add pre-DAC digital mux controls

[Mark Brown]

On Mon, Dec 01, 2008 at 03:25:12PM +0200, Peter Ujfalusi wrote:

> In respect of PM, there is no power control before the DACs in TWL.
> A simple chain looks like this (I2S stereo playback to HeadSet):

It's not just the DACs themselves, it's everything after the DACs too.
If DAPM thinks a DAC is powered off it won't power anything that has
inputs connected only to that DAC up.

> What I'm trying to do with the DAPM at the moment:
> Have the MUX settings tied to the outputs.
> Based on the selected input (to the output), connect it to the correct APGA 
> with power switch.
> APGA connects to the corresponding DAC with power switch.

In general you should only have user-visible switches for things that
are conditionally connected.  If the APGA can only source input from a
single DAC then let DAPM figure out if it needs to be turned on based on
the inputs and outputs.  This is often important for amplifiers which
may pass signals through unexpectedly when powered down.

> How it will affect the existing codec drivers?

The changes are all on the device registration side so for the stuff
you're doing there should be no substantial effect - the other parts
have already been merged.