[alsa-devel] [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 and a few minor fixes

[Takashi Iwai]

At Thu, 28 Aug 2008 16:09:27 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> Changelog:
> * added info about PHASE 28 (as far as I could collect, I don't have a card)
> * added info about TS22PCI and new revisions of PHASE 22
> * disable 192k on PHASE 22 as AK4524 I2S doesn't support it
> * enable midi for both PHASE 22 and PHASE 28
> * enable SPDIF reciever on PHASE 22
> 
> MIDI works for me, I have tried loopback and it plays good. Thanks for
> help Pavel and Takashi.

Thanks, the changes look almost good to me.

Could you fix the following and add your sign-off for merging to the
upstream?  (And add me to Cc so that I get your post directly.)


> diff --git a/pci/ice1712/phase.c b/pci/ice1712/phase.c
> index f5acdee..6e596e9 100644
> --- a/pci/ice1712/phase.c
> +++ b/pci/ice1712/phase.c
> @@ -24,7 +24,8 @@
>  /* PHASE 22 overview:
>   *   Audio controller: VIA Envy24HT-S (slightly trimmed down version
> of Envy24HT)

The embedded mail seems broken - see line breaks.
If it's hard to fix your MUA, use an attachment instead.

>   *   Analog chip: AK4524 (partially via Philip's 74HCT125)
> - *   Digital receiver: CS8414-CS (not supported in this release)
> + *   Digital receiver: CS8414-CS (supported in this release)
> + *		PHASE 22 revision 2.0 and Terrasoniq/Musonik TS22PCI have CS8416
> (support status unknown, please test and report)

Try to keep the newly added lines to fit in 80 chars as much as
possible.


thanks,

Takashi