[alsa-devel] [PATCH] ASoC: Fix double free and memory leak in many codec drivers

Takashi Iwai tiwai at suse.de
Mon Aug 25 13:53:10 CEST 2008


At Mon, 25 Aug 2008 11:49:20 +0100,
Mark Brown wrote:
> 
> From: Jean Delvare <khali at linux-fr.org>
> 
> Many SoC audio codec drivers have improper freeing of memory in error
> paths.
> 
> * codec is allocated in the platform device probe function, but is not
>   freed there in case of error. Instead it is freed in the i2c device
>   probe function's error path. However the success or failure of both
>   functions is not linked, so this could result in a double free (if
>   the platform device is successfully probed, the i2c device probing
>   fails and then the platform driver is unregistered.)
> 
> * codec->private_data is allocated in many platform device probe
>   functions but not freed in their error paths.
> 
> This patch hopefully solves all these problems.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>

This looks like a 2.6.27 material, right?
I applied to for-linus branch now.  Thanks.


Takashi


More information about the Alsa-devel mailing list