[alsa-devel] [PATCH] opl3sa2: drop snd_card pointer from the snd_opl3sa2 structure
Krzysztof Helt
krzysztof.h1 at poczta.fm
Sun Aug 17 22:39:10 CEST 2008
On Sun, 17 Aug 2008 20:26:10 +0200
Rene Herman <rene.herman at keyaccess.nl> wrote:
> > @@ -298,12 +296,14 @@ static int __devinit snd_opl3sa2_detect(
> > static irqreturn_t snd_opl3sa2_interrupt(int irq, void *dev_id)
> > {
> > unsigned short status;
> > - struct snd_opl3sa2 *chip = dev_id;
> > + struct snd_card *card = dev_id;
> > + struct snd_opl3sa2 *chip;
> > int handled = 0;
> >
> > - if (chip == NULL || chip->card == NULL)
> > + if (card == NULL || card->private_data == NULL)
>
> micro-comment: card->private_data can't actually be NULL on initialized
> card (it's card + n) but yes, I guess we're pretending we don't know that...
>
Right. The next opl3sa2 patch will fix this.
Regards,
Krzysztof
----------------------------------------------------------------------
Farmerzy tez maja Olimpiade!
Sprawdz >> http://link.interia.pl/f1edd
More information about the Alsa-devel
mailing list