[alsa-devel] [PATCH] ASoC: Add WM8580 CODEC driver

[Takashi Iwai]

At Wed,  6 Aug 2008 13:18:26 +0100,
Mark Brown wrote:
> 
> +static inline unsigned int wm8580_read(struct snd_soc_codec *codec,
> +				       unsigned int reg)
> +{
> +	switch (reg) {
> +	default:
> +		return wm8580_read_reg_cache(codec, reg);
> +	}

Any addition in future?  Otherwise let's remove unneeded switch.

> +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)

Could you rewrite the code to follow the recent i2c framework?
Then you can reduce lots of codes.


thanks,

Takashi