[alsa-devel] [PATCH 05/11] wss_lib: use wss constants instead of ad1848 ones

[krzysztof.h1 at poczta.fm]

> On 31-07-08 21:05, Krzysztof Helt wrote:
> 
> > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > 
> > Use wss constants for mode.
> > Move ad1848 hardware constants to the wss.h.
> > Move mixer tlv macros into the ad1848_lib.c from the ad1848.h.
> > 
> > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > ---
> > 
> > Changes since previous version:
> > 
> > 1. No reformatting of switch in the ad1848_lib.c
> >    in the snd_ad1848_chip_id() as the file is going
> >    to be killed anyway.
> 
> Still a little uneasy about the loss of MODE_RUNNING given that the 
> original looked as something noone would've added without a specific 
> need but I guess we can keep it in mind and match it up with any 
> possible regressions.
> 
> I _would_ very much like a comment in the changelog about it. It's 
> unlikely to be a regression that would be reported quickly with this 
> being old hardware generally. Something like:
> 
> "Drop the MODE_RUNNING spurious IRQ guard on AD1848 as it doesn not seem 
> to be needed."
> 

Arghhh. I forgot this. You have mentioned it previously.
Takashi, is it possible to add something to patch's description?


> Otherwise:
> 
> Acked-by: Rene Herman <rene.herman at gmail.com>
> 
> Rene.
> 
> 

Regards,
Krzysztof

----------------------------------------------------------------------
Tani Telefon!
Sprawdz >>>  http://link.interia.pl/f1ec0