[alsa-devel] [PATCH] cs4231: remove two auto-calibrations during chip initialization

[Jaroslav Kysela]

On Tue, 18 Sep 2007, Rene Herman wrote:

> On 09/18/2007 12:17 PM, Krzysztof Helt wrote:
> 
> > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > 
> > The initialization function did auto-calibration after each
> > register setting. This patch merges more register changes
> > before auto-calibration is done.
> 
> Seems to make sense but am a little uneasy about these -- someone very much
> did it this way on purpose originally it seems. Jaroslav, that someone was you
> I believe? Do you remember anything about this?

If I remember correctly, it was workaround for some CS4231 chips to fix 
the noise audio issue (the chip was not initialized correctly in some 
cases). I would make a whitelist for "non-buggy" tested chips to skip 
double calibration.

						Jaroslav

-----
Jaroslav Kysela <perex at suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs