[alsa-devel] [PATCH] cs4231-lib: improved waiting after mce_down (2nd rev)

[Takashi Iwai]

At Tue, 11 Sep 2007 00:43:42 +0200,
Rene Herman wrote:
> 
> Second -- not schedule_timeout_interruptible? A plain schedule_timeout won't 
> work, as you first need to __set_current_state or it will not schedule. That 
> is, schedule_timeout_interruptible or _uniterruptible and with the latter, 
> the loop wouldn't make much sense anymore as it's just going to sleep for 
> the full 250 ms directly.

Ah, right.  I'm obviously too sleepy to review now...

Actually, the code with msleep() was basically OK.  If more finer
check is needed, it can simply use msleep(1).  The point is to use
timer_after_eq() instead of loop count for the precise timeouts.


thanks,

Takashi