[alsa-devel] [PATCH] Improved support for different bt87x board configurations

Takashi Iwai tiwai at suse.de
Wed Sep 5 12:16:37 CEST 2007


At Tue, 4 Sep 2007 04:49:46 -0700 (PDT),
Trent Piepho wrote:
> 
> -	BT_DEVICE(PCI_DEVICE_ID_BROOKTREE_878, 0x0070, 0x13eb, 32000),
> +	BT_DEVICE(_878, 0x0070, 0x13eb, SND_BT87X_BOARD_HAUPPAUGE878),

It's a bad move.  As Clemens pointed, it was in a similar expression
in the earlier version, but we changed to the form with
PCI_DEVICE_ID_ prefix *intentionally* after complains from kernel
hackers (and that was reasonable).  If the length of a line really
matters, we can drop SND_BT87X_ prefix from the board enum items
instead.


thanks,

Takashi


More information about the Alsa-devel mailing list