[alsa-devel] [PATCH] Improved support for different bt87x board configurations

[Takashi Iwai]

At Tue, 04 Sep 2007 14:54:39 +0100,
Mauro Carvalho Chehab wrote:
> 
> 
> > Ok, that's what I did.  The other checkpatch warnings are fixed too. 
>  
> > +/* Cards with configuration information */
> > +enum snd_bt87x_boardid {
> > +       SND_BT87X_BOARD_GENERIC,
> > +       SND_BT87X_BOARD_ANALOG,         /* board with no external A/D
> > */
> > +       SND_BT87X_BOARD_HAUPPAUGE878,
> > +       SND_BT87X_BOARD_OSPREY2x0,
> > +       SND_BT87X_BOARD_OSPREY440,
> > +       SND_BT87X_BOARD_ATI_TVWONDER,
> > +       SND_BT87X_BOARD_WINFAST2000,
> > +       SND_BT87X_BOARD_VOODOOTV_200,
> > +       SND_BT87X_BOARD_AVPHONE98,
> 
> Hmm... Maybe it would be a good idea to move the board numbers from
> linux/drivers/media/video/bt8xx/bttv.h to a separate header (maybe
> something like /include/media/bt8xx-cards.h) and use the same board IDs
> for both -alsa and -v4l drivers.
> 
> This will make easier to associate the audio and video parts for
> troubleshooting and newer developments.

Yes, it sounds like a good idea.


Takashi