[alsa-devel] [PATCH] Gallant SC-6000 driver (2nd version)

[Takashi Iwai]

At Mon, 3 Sep 2007 22:30:00 +0200,
Krzysztof Helt wrote:
> 
> +static int __devinit sc6000_init_mss(int port, int config, int mss_port,
> +				     int mss_config)
> +{
> +	if (sc6000_write(port, DSP_INIT_MSS)) {
> +		snd_printk(KERN_ERR "sc6000_init_mss [0x%x]: failed!\n",
> +			   DSP_INIT_MSS);
> +		return -EIO;
> +	}
> +
> +	mdelay(10);

Can it be msleep?

> +static int __devinit snd_sc6000_probe(struct device *devptr, unsigned int dev)
> +{
> +	static int possible_irqs[] = { 7, 9, 10, 11, -1 };
> +	static int possible_dmas[] = { 1, 3, 0, -1 };
> +	int err;
> +	int xirq = irq[dev];
> +	int xdma = dma[dev];
> +	struct snd_card *card;
> +	struct snd_ad1848 *chip;
> +	struct snd_opl3 *opl3;
> +
> +	card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
> +	if (card == NULL)

"if (!card)" is preferred by many kernel guys, but there is no strict
rule, AFAIK.


thanks,

Takashi