[alsa-devel] [PATCH] sun-cs4231: code improvements

Takashi Iwai tiwai at suse.de
Mon Sep 3 14:58:52 CEST 2007


At Sun, 2 Sep 2007 22:16:15 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> 
> This patch does some code improvements to make
> driver (both code and binary) shorter.
> It also make use of card->private_data pointer to
> store chip information.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>

The change looks OK.  But, again, please fix "if ((err = ...))", at
least, for the lines we change.


Thanks,

Takashi


More information about the Alsa-devel mailing list