[alsa-devel] 1.0.15rc3 patch_analog.s bug + fix

[Takashi Iwai]

At Tue, 16 Oct 2007 21:30:50 +0300,
Vasily Khoruzhick wrote:
> 
> > At Tue, 16 Oct 2007 10:39:55 +0300,
> >
> > Vasily Khoruzhick wrote:
> > > [1  <text/plain; iso-8859-1 (quoted-printable)>]
> > >
> > > On Monday 15 October 2007 23:34:21 Peter Skensved wrote:
> > > > > Hmm, the code logic looks correct to me.  If HP jack is present, the
> > > > > internal speaker should be muted.  Otherwise it follows the state of
> > > > > HP jack (muted/unmuted, that acts as a master switch)
> > >
> > > Code logic is broken.
> > > Internal speakers muted while jack unplugged and unmuted while it's
> > > plugged.
> >
> > No, it's the wrong logic.  The internal speaker should be unmuted when
> > HP is unplugged, and muted when plugged.  You don't want to hear from
> > both at the same time.
> >
> 
> Sorry, i've made mistake, of course internal speakers should be muted when 
> jack plugged. Patch that I've attached to previous message has exactly that 
> logic.

Well, the point is that the logic in your patch was a bit confusing.
"present" should have been renamed as "not_present" or so...

> > This implies rather that the jack detection itself is reversed from
> > the standard.  Could you try the patch below?
> 
> Your patch works.

Thanks for confirmation.  Now applied to HG tree.

> But it seems that there's another bug - i have loud click when i to play 
> something or change mixer settings after not using audio for ~1min

I guess it's likely the auto power-saving feature.
Could you set the module option power_save=0 for snd-hda-intel?


thanks,

Takashi