[alsa-devel] snd-hdsp in 2.6.22 crashes badly

[Takashi Iwai]

At Sun, 14 Oct 2007 22:21:22 +0000,
ilya .d wrote:
> 
> Hello.
> 
> i'm using RME Hammerfall HDSP9632..
> it worked fine with 2.6.17 and 2.6.20 (-gentoo), i don't think gentoo
> team modifies alsa tree ..
> 
> as soon as i upgraded to 2.6.22[-gentoo-r8], it booted fine, but when i
> started gnome-settigs-daemon, kernell generated OOPS, and i couldn't
> inload the module with modprobe.
> 
> i disabled gnome-settings-daemon, and reboot.
> i managed to use hdspconf , hdspmixer + a couple of applications
> (puredata and snd editor), it was all good.
> as soon as i ran alsamixer (well , normaly you don't need it for
> snd-hdsp, but i wanted to configure my second soundcard, which is
> SB_live, but forgot to give it '-c 1') - so here the same crash heppends.
> 
> i tried 2.6.20 back - and all absolutely fine with it.
> 
> looking at hdsp.c in both kernels i spoted quite a few changes , however
> i don't know much about it ;[
> 
> so i attached the details below.

Does the patch below fix the problem?


Thanks,

Takashi

diff -r 29661bff769f pci/rme9652/hdsp.c
--- a/pci/rme9652/hdsp.c	Mon Oct 15 10:36:45 2007 +0200
+++ b/pci/rme9652/hdsp.c	Mon Oct 15 13:59:20 2007 +0200
@@ -3058,6 +3058,9 @@ static int hdsp_dds_offset(struct hdsp *
 	u32 r;
 	unsigned int dds_value = hdsp->dds_value;
 	int system_sample_rate = hdsp->system_sample_rate;
+
+	if (!dds_value)
+		return 0;
 
 	n = DDS_NUMERATOR;
 	/*