[alsa-devel] [PATCH] sound/isa: kill pnp_resource_change.

[Jaroslav Kysela]

On Fri, 30 Nov 2007, Takashi Iwai wrote:

> At Fri, 30 Nov 2007 13:25:22 +0100 (CET),
> Jaroslav Kysela wrote:
> > 
> > On Fri, 30 Nov 2007, Takashi Iwai wrote:
> > 
> > > At Fri, 30 Nov 2007 10:52:26 +0100 (CET),
> > > Jaroslav Kysela wrote:
> > > > 
> > > > On Thu, 29 Nov 2007, Takashi Iwai wrote:
> > > > 
> > > > > At Thu, 29 Nov 2007 02:10:33 +0100,
> > > > > Rene Herman wrote:
> > > > > > 
> > > > > > Hi Takashi.
> > > > > > 
> > > > > > This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
> > > > > > 2.4 these were useful in providing an easy path to setting the resources,
> > > > > > but in 2.6 they retain function as a layering violation only.
> > > > > > 
> > > > > > This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
> > > > > > only remaining user of pnp_init_resource_table(), pnp_resource_change() and
> > > > > > pnp_manual_config_dev() (and, in fact, of "struct pnp_resource_table") in
> > > > > > the tree outide of drivers/pnp itself meaning it makes for more cleanup
> > > > > > potential inside the PnP layer.
> > > > > > 
> > > > > > Thomas Renninger acked their removal from that side, you did from the ALSA
> > > > > > side (CC list just copied from that thread).
> > > > > > 
> > > > > > Against current alsa-kernel HG. Many more potential cleanups in there, but 
> > > > > > this _only_ removes the pnp_resource_change code. Compile tested against 
> > > > > > current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few 
> > > > > > offsets).
> > > > > > 
> > > > > > Signed-off-by: Rene Herman <rene.herman at gmail.com>
> > > > > 
> > > > > A good work.  I'll merge this tomorrow to ALSA tree if no one raises
> > > > > objection now.
> > > > 
> > > > Do we have a nice way to manually assign ISA resources at system level? 
> > > > Note that not all combinations work for all ISA PnP soundcards and we had bug 
> > > > reports that automatic PnP system failed in some cases.
> > > 
> > > You can adjust it via sysfs.
> > 
> > Ok, then we need to document this way properly in our documentation before 
> > feature removal.
> 
> Yes, see Bjorn's previous post.
> 
> > Probably using 'install' commmand in modprobe.conf. Also 
> > note that user must probably know exact sysfs path (PnP ID) making PnP 
> > stuff more complicated in this case. It is different from current 
> > behaviour.
> 
> Such a device requring the manual configuration is basically broken.
> It should be fixed, e.g. by adding a quirk to pnp driver.

Note that in some cases, it's not about a device, but about motherboard 
and device interoperability. I've seen some ISA motherboards with some 
unusable DMA channels.

Anyway, it's true that ISA PnP stuff is quite obsolete current days.
If manual settings is supported and described, I've no objections to 
reduce code, too.

						Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project