[alsa-devel] [PATCH] sound/isa: kill pnp_resource_change.

Bjorn Helgaas bjorn.helgaas at hp.com
Thu Nov 29 17:20:04 CET 2007


On Wednesday 28 November 2007 06:10:33 pm Rene Herman wrote:
> This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
> 2.4 these were useful in providing an easy path to setting the resources,
> but in 2.6 they retain function as a layering violation only.
> 
> This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
> only remaining user of pnp_init_resource_table(), pnp_resource_change() and
> pnp_manual_config_dev() (and, in fact, of "struct pnp_resource_table") in
> the tree outide of drivers/pnp itself meaning it makes for more cleanup
> potential inside the PnP layer.

I think this is great and will certainly clean up the PNP interfaces.

But are you removing functionality that people need?  I don't know
anything about ALSA, but we have to assume that some BIOSes supply
incorrect resource information.  If you remove all these module
parameters, is there still a way to workaround the BIOS defects?

Bjorn



More information about the Alsa-devel mailing list