[alsa-devel] [PATCH] add number of periods constraint to snd-aoa

Heikki O Lindholm holindho at cs.helsinki.fi
Fri Nov 23 10:43:31 CET 2007


From: Heikki Lindholm <holindho at cs.helsinki.fi>

The aoa driver is not specifying constraints on number of periods, and, it 
seems, it might end with a non-integer number, which it cannot deal with. 
Fix by adding a proper constraint.

Signed-off-by: Heikki Lindholm  <holindho at cs.helsinki.fi>
---
diff -r 1b54a8725ded aoa/soundbus/i2sbus/i2sbus-pcm.c
--- a/aoa/soundbus/i2sbus/i2sbus-pcm.c	Wed Nov 14 17:07:17 2007 +0100
+++ b/aoa/soundbus/i2sbus/i2sbus-pcm.c	Fri Nov 23 11:35:17 2007 +0200
@@ -196,7 +196,10 @@ static int i2sbus_pcm_open(struct i2sbus
 	hw->periods_max = MAX_DBDMA_COMMANDS;
 	list_for_each_entry(cii, &sdev->codec_list, list) {
 		if (cii->codec->open) {
-			err = cii->codec->open(cii, pi->substream);
+			if ((err = cii->codec->open(cii, pi->substream)) == 0)
+				err = snd_pcm_hw_constraint_integer(
+					pi->substream->runtime,
+					SNDRV_PCM_HW_PARAM_PERIODS);
 			if (err) {
 				result = err;
 				/* unwind */


More information about the Alsa-devel mailing list