[alsa-devel] [PATCH 2/2] caiaq/NativeInstruments: control support

[Daniel Mack]

On Wed, Nov 21, 2007 at 11:01:54AM +0100, Takashi Iwai wrote:
> > +#ifdef CONFIG_SND_USB_CAIAQ_INPUT
> > +#include <linux/input.h>
> > +#endif
> 
> Do you really need ifdef here?

No, I agree. Also removed that from other places.

> The put callback is supposed to return 1 if a value is changed.
> It's no strict requirement, so far, but if this still doesn't follow
> put a comment like FIXME. 

Changed.

> > +/*
> > + *
> > + * 0
> > + * 1 << 1
> > + * 1 << 0 | 1 << 1
> > + * 1 << 0 | 1 << 1 | 1 << 2
> > + * 1 << 0
> > + * 0
> > + *
> > + */
> 
> What's this? :)

I developement left-over - I'm still not yet used to git-update-index ;)

New version attached.

Greets,
Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: alsa-caiaq-1.3.0.diff
Type: text/x-diff
Size: 24767 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20071121/aca9d09e/attachment-0001.bin