[alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

Takashi Iwai tiwai at suse.de
Wed Nov 21 10:53:54 CET 2007


At Tue, 20 Nov 2007 15:31:26 +0100,
Rene Herman wrote:
> 
> On 20-11-07 15:19, Thomas Renninger wrote:
> 
> > At the end is some example code how things could get even more cleaned
> > up. It shows how I think pnp layer and one example driver would get
> > adjusted. There are not that much drivers making use of
> > pnp_resource_change...
> 
> The ALSA ISA-PnP drivers do in what I personally consider a bad layering 
> violation. Brought up not doing that a while ago on alsa-devel, but no 
> discussion ensued. If the PnP maintainer(s) agree with me though, I'd be 
> more than happy to rip all of that out of ALSA.

I'm fine with removal of that stuff now.  It was implemented in that
way because there was no proper way to re-assign ISA PnP resources on
2.4 kernel time.  On 2.6, it makes no longer any sense (except for
compatibility, but this is almost no problem for PnP boards).


thanks,

Takashi


More information about the Alsa-devel mailing list