[alsa-devel] [PATCH] Add ASoC AK4535 codec driver.

[Takashi Iwai]

At Tue, 20 Nov 2007 15:05:30 +0000,
Mark Brown wrote:
> 
> On Tue, Nov 20, 2007 at 11:40:25AM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > +config SND_SOC_AK4535
> > > +	tristate
> > > +	depends on SND_SOC
> > > +
> 
> > Unless you add another interface support, this driver seems only for
> > I2C.  Then let's add dependency on I2C (which will avoid a possible
> > unresolved symbol error).
> 
> The idiom used by the rest of the ASoC codecs appears to be to omit the
> bus dependencies entirely from the codec drivers and rely on the machine
> driver pulling in the appropriate bus driver.  For the sake of
> consistency I'd rather leave this just now and then separately go
> through and address this for all drivers at once - does that seem
> sensible to you?

Well, the problem is that the dependency with I2C is incomplete right
now.  We may build ASOC=y and I2C=m, and you'll get unresolved symbols
due to call of I2C function from asoc.

I'm not sure what is the proper way to fix this.  If the codec driver
supports non-I2C and can be built without it, the explicit dependency
on I2C is of course wrong.


Takashi