[alsa-devel] [PATCH] Add Amesom ASoC machine support.

[Takashi Iwai]

At Tue, 20 Nov 2007 09:25:42 +0000,
Mark Brown wrote:
> 
> --- /dev/null
> +++ b/sound/soc/pxa/amesom_tlv320.c
(snip)
> +static struct snd_soc_machine amesom;

Looks superfluous.

> +/*
> + * Tlv320 uses SSP port for playback.
> + */
> +static int tlv320_voice_hw_params(struct snd_pcm_substream *substream,
> +	struct snd_pcm_hw_params *params)
> +{
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct snd_soc_codec_dai *codec_dai = rtd->dai->codec_dai;
> +	struct snd_soc_cpu_dai *cpu_dai = rtd->dai->cpu_dai;
> +	int ret = 0;
> +
> +	//printk("tlv320_voice_hw_params enter\n");

Avoid C++ style comments.

> +	switch(params_rate(params)) {

Add space between switch and the parenthesis.


Takashi