[alsa-devel] Question to integrate a new driver

[Lee Revell]

On 5/16/07, Jean-Christian Hassler <jhassler at free.fr> wrote:
> I wrote with a friend an ALSA driver for the emagic AUDIOWERK 2
> soundcard. Now it works for the analog inputs/outputs.
>
> The project page is here : http://home.gna.org/aw2-alsa/index.html
>
> We have 2 questions to continue our work :
> 1- what is the way to submit our code to be integrated in the ALSA
> tree ?

Post to alsa-devel as a patch against ALSA Hg sources.  Include
signed-off-by line and description.  See alsa-devel archives for some
examples.

> 2- We develop on two different version of the kernel (2.6.17-14 &
> 2.6.20) and the request_irq function prototype has changed between these
> two versions(the "struct pt_regs *" does no longer exists), how is this
> managed in ALSA ?

Post a patch against latest alsa sources and the ALSA build process
will automagically patch the code so it can be build against older
kernels.  No need to worry about old kernels in your driver.

Some minor kernel coding style issues to fix before submitting:

Don't use StudlyCaps (pcmDevice->streamNumber should be
pcm_device->stream_number)
Don't use typedefs for structs
Preferred if/else style is:
if (foo) {
    stuff;
} else {
    other_stuff;
}
Use DMA_32BIT_MASK constant rather than 0xffffffff
Don't use C++ style comments (//)

Lee