[alsa-devel] [PATCH] SH7760 ASoC support

[Manuel Lauss]

On Thu, May 10, 2007 at 09:58:17PM +0900, Paul Mundt wrote:
> On Thu, May 10, 2007 at 02:08:33PM +0200, Manuel Lauss wrote:
> > +##
> > +## Audio unit modules
> > +##
> > +
> > +config SND_SOC_SH4_HAC
> > +	select AC97_BUS
> > +	select SND_SOC_AC97_BUS
> > +	select SND_AC97_CODEC
> > +	tristate
> > +
> > +config SND_SOC_SH4_SSI
> > +	tristate
> > +
> This might seem like a silly question, but how are these two supposed to
> be enabled? At the very least you should have some dependencies on the
> CPU subtypes that support these blocks.
> 
> > +
> > +
> > +##
> > +## Boards
> > +##
> > +
> Or are you expecting that the board-specific code will simply select
> these?

That was the idea; the other ASoC boards do similar things.
 
> Are you planning on submitting a stub that enables these? Or is this just
> to be a placeholder until some board wants them?

I suppose I can submit my AC97 board code, it does not depend
on anything that is not already submitted.

I'll add the ac97 board code to the patch and re-submit it.

Thanks,
	Manuel Lauss