[alsa-devel] [PATCH] ALSA: Support Media Vision Jazz16 chips

[Rene Herman]

On 03/27/2007 02:32 AM, Rask Ingemann Lambertsen wrote:

>> The hardware fundamentally supports just one card per system due to the 
>> fixed config port, so you might as well get rid of the dev_num (and the 
>> SNDRV_CARDS-wide arrays) it seems?. If you want to keep them that way 
>> just so that it's more generic looking... sure.
> 
>    Also, if someone, somehow, manages to have two of these cards, I would
> find it unforgivable if it didn't just work. According to this press
> release
> <URL:http://findarticles.com/p/articles/mi_m0NEW/is_1993_July_23/ai_14099965>,
> there should be motherboards with Jazz16 chips on them, presumably to be
> configured using the PnPBIOS (the specification for which was released in
> 1994). It might still be possible to have a stand-alone Jazz16 card in
> addition to an on-board one.

Okay, fair enough.

>> Single statement branches don't have braces in the kernel coding style.
> 
>    OK. Documentation/CodingStyle should probably say so.

Linux kernel coding style is (un)fortunately a rather hodge-podge mix of 
written and unwritten rules. It's not random though -- reading reviews 
by other developers helps...

The snd_card_set_dev() was the other non-trivial thing in there. Was 
that logged?

Rene.