No subject

578         if ((chip->mode & AD1848_MODE_PLAY) && chip->playback_substream &&
579             (chip->mode & AD1848_MODE_RUNNING))
580                 snd_pcm_period_elapsed(chip->playback_substream);

Another CPU could close the substream between the check and the call to
snd_pcm_period_elapsed().  snd_pcm_period_elapsed() could be called with
either NULL or a stale substream pointer depending on how the code compiled.
I'd think creating an irq spinlock would be an easy way to fix this.  The irq
handler would grab it, and the same with the open() and close() functions
around the code that sets the substream pointers.  Alternatively, one could
disabled the irq handler during open and close.

I think there might also be problem with setting mixers controls during
auto-calibration .  While waiting for auto-calibration to finish, the chip
isn't locked.  If another thread tries to set the volume via the mixer
interface, it won't be blocked and will try to talk to the chip during AC.
The datasheet just says to wait for auto-calibration to finish, it doesn't say
what happens if you don't.  So maybe there isn't any problem here.
--289736052-2121362787-1190179362=:27377
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ad1848_swa.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.58.0709182222420.27377 at shell4.speakeasy.net>
Content-Description: 
Content-Disposition: attachment; filename="ad1848_swa.patch"

YWQxODQ4OiBGaXggbXNsZWVwIHdoaWxlIGF0b21pYw0KDQpTaW1wbGVzdCBm
aXguDQoNClNpZ25lZC1vZmYtYnk6IFRyZW50IFBpZXBobyA8eHl6enlAc3Bl
YWtlYXN5Lm9yZz4NCkFja2VkLWJ5OiBSZW5lIEhlcm1hbiA8cmVuZS5oZXJt
YW5AZ21haWwuY29tPg0KDQpkaWZmIC1yIDUwNTAyYzEzZDJjZiBpc2EvYWQx
ODQ4L2FkMTg0OF9saWIuYw0KLS0tIGEvaXNhL2FkMTg0OC9hZDE4NDhfbGli
LmMJTW9uIFNlcCAxNyAxOTowODozMiAyMDA3ICswMjAwDQorKysgYi9pc2Ev
YWQxODQ4L2FkMTg0OF9saWIuYwlNb24gU2VwIDE3IDE5OjE5OjUyIDIwMDcg
LTA3MDANCkBAIC0yMzYsNyArMjM2LDkgQEAgc3RhdGljIHZvaWQgc25kX2Fk
MTg0OF9tY2VfZG93bihzdHJ1Y3Qgcw0KIAkgKiBjYWxpYnJhdGlvbiBwcm9j
ZXNzIHRvIHN0YXJ0LiBOZWVkcyB1cHRvIDUgc2FtcGxlIHBlcmlvZHMgb24g
QUQxODQ4DQogCSAqIHdoaWNoIGF0IHRoZSBzbG93ZXN0IHBvc3NpYmxlIHJh
dGUgb2YgNS41MTI1IGtIeiBtZWFucyA5MDcgdXMuDQogCSAqLw0KKwlzcGlu
X3VubG9ja19pcnFyZXN0b3JlKCZjaGlwLT5yZWdfbG9jaywgZmxhZ3MpOw0K
IAltc2xlZXAoMSk7DQorCXNwaW5fbG9ja19pcnFzYXZlKCZjaGlwLT5yZWdf
bG9jaywgZmxhZ3MpOw0KIA0KIAlzbmRfcHJpbnRkZCgiKDIpIGppZmZpZXMg
PSAlbHVcbiIsIGppZmZpZXMpOw0KIA0K

--289736052-2121362787-1190179362=:27377
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ad1848.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.58.0709182222421.27377 at shell4.speakeasy.net>
Content-Description: 
Content-Disposition: attachment; filename="ad1848.patch"

YWQxODQ4OiBzaW1wbGlmeSBNQ0UgZG93biBjb2RlDQoNClRoZSBwb2xsaW5n
IGxvb3AgdG8gY2hlY2sgZm9yIEFDSSB0byBnbyBkb3duIHdhcyBtb3JlIGNv
bnZvbHV0ZWQgdGhhbiBpdA0KbmVlZGVkIHRvIGJlLiAgTmV3IGxvb3Agc2hv
dWxkIGJlIG1vcmUgZWZmaWNpZW50IGFuZCBpdCBpcyBhIGxvdCBzaW1wbGVy
LiAgVGhlDQpvbGQgbG9vcCBjaGVja2VkIGZvciBhIHRpbWVvdXQgYmVmb3Jl
IGNoZWNraW5nIGZvciBBQ0kgZG93biwgd2hpY2ggY291bGQNCnJlc3VsdCBp
biBhbiBlcnJvbmVvdXMgdGltZW91dC4gIEl0J3Mgb25seSBhIGZhaWx1cmUg
aWYgdGhlIHRpbWVvdXQgZXhwaXJlcw0KX2FuZF8gQUNJIGlzIHN0aWxsIGhp
Z2guICBUaGVyZSBpcyBub3RoaW5nIHdyb25nIHdpdGggdGhlIHRpbWVvdXQg
ZXhwaXJpbmcNCndoaWxlIHRoZSB0YXNrIGlzIHNsZWVwaW5nIGlmIEFDSSB3
ZW50IGxvdy4NCg0KQSBwb2xsaW5nIGxvb3AgdG8gY2hlY2sgZm9yIHRoZSBk
ZXZpY2UgdG8gbGVhdmluZyBJTklUIG1vZGUgaXMgcmVtb3ZlZC4gIFRoZQ0K
ZGV2aWNlIG11c3QgaGF2ZSBhbHJlYWR5IGxlZnQgaW5pdCBmb3IgdGhlIHBy
ZXZpb3VzIEFDSSBsb29wIHRvIGhhdmUgZmluaXNoZWQuDQoNClNpZ25lZC1v
ZmYtYnk6IFRyZW50IFBpZXBobyA8eHl6enlAc3BlYWtlYXN5Lm9yZz4NCkFj
a2VkLWJ5OiBSZW5lIEhlcm1hbiA8cmVuZS5oZXJtYW5AZ21haWwuY29tPg0K
DQpkaWZmIC1yIGVjOTYyODNhMjczZiBpc2EvYWQxODQ4L2FkMTg0OF9saWIu
Yw0KLS0tIGEvaXNhL2FkMTg0OC9hZDE4NDhfbGliLmMJTW9uIFNlcCAxNyAx
OToyMDo0OCAyMDA3IC0wNzAwDQorKysgYi9pc2EvYWQxODQ4L2FkMTg0OF9s
aWIuYwlUdWUgU2VwIDE4IDE5OjI2OjQyIDIwMDcgLTA3MDANCkBAIC0yMDMs
OSArMjAzLDggQEAgc3RhdGljIHZvaWQgc25kX2FkMTg0OF9tY2VfdXAoc3Ry
dWN0IHNuZA0KIA0KIHN0YXRpYyB2b2lkIHNuZF9hZDE4NDhfbWNlX2Rvd24o
c3RydWN0IHNuZF9hZDE4NDggKmNoaXApDQogew0KLQl1bnNpZ25lZCBsb25n
IGZsYWdzOw0KLQlpbnQgdGltZW91dDsNCi0JdW5zaWduZWQgbG9uZyBlbmRf
dGltZTsNCisJdW5zaWduZWQgbG9uZyBmbGFncywgdGltZW91dDsNCisJaW50
IHJlZzsNCiANCiAJc3Bpbl9sb2NrX2lycXNhdmUoJmNoaXAtPnJlZ19sb2Nr
LCBmbGFncyk7DQogCWZvciAodGltZW91dCA9IDU7IHRpbWVvdXQgPiAwOyB0
aW1lb3V0LS0pDQpAQCAtMjIyLDUwICsyMjEsMzYgQEAgc3RhdGljIHZvaWQg
c25kX2FkMTg0OF9tY2VfZG93bihzdHJ1Y3Qgcw0KICNlbmRpZg0KIA0KIAlj
aGlwLT5tY2VfYml0ICY9IH5BRDE4NDhfTUNFOw0KLQl0aW1lb3V0ID0gaW5i
KEFEMTg0OFAoY2hpcCwgUkVHU0VMKSk7DQotCW91dGIoY2hpcC0+bWNlX2Jp
dCB8ICh0aW1lb3V0ICYgMHgxZiksIEFEMTg0OFAoY2hpcCwgUkVHU0VMKSk7
DQotCWlmICh0aW1lb3V0ID09IDB4ODApDQorCXJlZyA9IGluYihBRDE4NDhQ
KGNoaXAsIFJFR1NFTCkpOw0KKwlvdXRiKGNoaXAtPm1jZV9iaXQgfCAocmVn
ICYgMHgxZiksIEFEMTg0OFAoY2hpcCwgUkVHU0VMKSk7DQorCWlmIChyZWcg
PT0gMHg4MCkNCiAJCXNuZF9wcmludGsoS0VSTl9XQVJOSU5HICJtY2VfZG93
biBbMHglbHhdOiBzZXJpb3VzIGluaXQgcHJvYmxlbSAtIGNvZGVjIHN0aWxs
IGJ1c3lcbiIsIGNoaXAtPnBvcnQpOw0KLQlpZiAoKHRpbWVvdXQgJiBBRDE4
NDhfTUNFKSA9PSAwKSB7DQorCWlmICgocmVnICYgQUQxODQ4X01DRSkgPT0g
MCkgew0KIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2hpcC0+cmVnX2xv
Y2ssIGZsYWdzKTsNCiAJCXJldHVybjsNCiAJfQ0KIA0KIAkvKg0KLQkgKiBX
YWl0IGZvciAocG9zc2libGUgLS0gZHVyaW5nIGluaXQgYXV0by1jYWxpYnJh
dGlvbiBtYXkgbm90IGJlIHNldCkNCi0JICogY2FsaWJyYXRpb24gcHJvY2Vz
cyB0byBzdGFydC4gTmVlZHMgdXB0byA1IHNhbXBsZSBwZXJpb2RzIG9uIEFE
MTg0OA0KLQkgKiB3aGljaCBhdCB0aGUgc2xvd2VzdCBwb3NzaWJsZSByYXRl
IG9mIDUuNTEyNSBrSHogbWVhbnMgOTA3IHVzLg0KKwkgKiBXYWl0IGZvciBh
dXRvLWNhbGlicmF0aW9uIChBQykgcHJvY2VzcyB0byBmaW5pc2gsIGkuZS4g
QUNJIHRvIGdvIGxvdy4NCisJICogSXQgbWF5IHRha2UgdXAgdG8gNSBzYW1w
bGUgcGVyaW9kcyAoYXQgbW9zdCA5MDcgdXMgQCA1LjUxMjUga0h6KSBmb3IN
CisJICogdGhlIHByb2Nlc3MgdG8gX3N0YXJ0Xywgc28gaXQgaXMgaW1wb3J0
YW50IHRvIHdhaXQgYXQgbGVhc3QgdGhhdCBsb25nDQorCSAqIGJlZm9yZSBj
aGVja2luZy4gIE90aGVyd2lzZSB3ZSBtaWdodCB0aGluayBBQyBoYXMgZmlu
aXNoZWQgd2hlbiBpdA0KKwkgKiBoYXMgaW4gZmFjdCBub3QgYmVndW4uICBJ
dCBjb3VsZCB0YWtlIDEyOCAobm8gQUMpIG9yIDM4NCAoQUMpIGN5Y2xlcw0K
KwkgKiBmb3IgQUNJIHRvIGRyb3AuICBUaGlzIGdpdmVzIGEgd2FpdCBvZiBh
dCBtb3N0IDcwIG1zIHdpdGggYSBtb3JlDQorCSAqIHR5cGljYWwgdmFsdWUg
b2YgMy05IG1zLg0KIAkgKi8NCi0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgm
Y2hpcC0+cmVnX2xvY2ssIGZsYWdzKTsNCi0JbXNsZWVwKDEpOw0KLQlzcGlu
X2xvY2tfaXJxc2F2ZSgmY2hpcC0+cmVnX2xvY2ssIGZsYWdzKTsNCi0NCi0J
c25kX3ByaW50ZGQoIigyKSBqaWZmaWVzID0gJWx1XG4iLCBqaWZmaWVzKTsN
Ci0NCi0JZW5kX3RpbWUgPSBqaWZmaWVzICsgbXNlY3NfdG9famlmZmllcygy
NTApOw0KLQl3aGlsZSAoc25kX2FkMTg0OF9pbihjaGlwLCBBRDE4NDhfVEVT
VF9JTklUKSAmIEFEMTg0OF9DQUxJQl9JTl9QUk9HUkVTUykgew0KKwl0aW1l
b3V0ID0gamlmZmllcyArIG1zZWNzX3RvX2ppZmZpZXMoMjUwKTsNCisJZG8g
ew0KIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2hpcC0+cmVnX2xvY2ss
IGZsYWdzKTsNCi0JCWlmICh0aW1lX2FmdGVyKGppZmZpZXMsIGVuZF90aW1l
KSkgew0KLQkJCXNuZF9wcmludGsoS0VSTl9FUlIgIm1jZV9kb3duIC0gYXV0
byBjYWxpYnJhdGlvbiB0aW1lIG91dCAoMilcbiIpOw0KLQkJCXJldHVybjsN
Ci0JCX0NCiAJCW1zbGVlcCgxKTsNCiAJCXNwaW5fbG9ja19pcnFzYXZlKCZj
aGlwLT5yZWdfbG9jaywgZmxhZ3MpOw0KLQl9DQotDQotCXNuZF9wcmludGRk
KCIoMykgamlmZmllcyA9ICVsdVxuIiwgamlmZmllcyk7DQotDQotCWVuZF90
aW1lID0gamlmZmllcyArIG1zZWNzX3RvX2ppZmZpZXMoMTAwKTsNCi0Jd2hp
bGUgKGluYihBRDE4NDhQKGNoaXAsIFJFR1NFTCkpICYgQUQxODQ4X0lOSVQp
IHsNCi0JCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmNoaXAtPnJlZ19sb2Nr
LCBmbGFncyk7DQotCQlpZiAodGltZV9hZnRlcihqaWZmaWVzLCBlbmRfdGlt
ZSkpIHsNCi0JCQlzbmRfcHJpbnRrKEtFUk5fRVJSICJtY2VfZG93biAtIGF1
dG8gY2FsaWJyYXRpb24gdGltZSBvdXQgKDMpXG4iKTsNCi0JCQlyZXR1cm47
DQotCQl9DQotCQltc2xlZXAoMSk7DQotCQlzcGluX2xvY2tfaXJxc2F2ZSgm
Y2hpcC0+cmVnX2xvY2ssIGZsYWdzKTsNCi0JfQ0KLQlzcGluX3VubG9ja19p
cnFyZXN0b3JlKCZjaGlwLT5yZWdfbG9jaywgZmxhZ3MpOw0KKwkJcmVnID0g
c25kX2FkMTg0OF9pbihjaGlwLCBBRDE4NDhfVEVTVF9JTklUKSAmDQorCQkg
ICAgICBBRDE4NDhfQ0FMSUJfSU5fUFJPR1JFU1M7DQorCX0gd2hpbGUgKHJl
ZyAmJiB0aW1lX2JlZm9yZShqaWZmaWVzLCB0aW1lb3V0KSk7DQorCXNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJmNoaXAtPnJlZ19sb2NrLCBmbGFncyk7DQor
CWlmIChyZWcpDQorCQlzbmRfcHJpbnRrKEtFUk5fRVJSDQorCQkJICAgIm1j
ZV9kb3duIC0gYXV0byBjYWxpYnJhdGlvbiB0aW1lIG91dCAoMilcbiIpOw0K
IA0KIAlzbmRfcHJpbnRkZCgiKDQpIGppZmZpZXMgPSAlbHVcbiIsIGppZmZp
ZXMpOw0KIAlzbmRfcHJpbnRkKCJtY2VfZG93biAtIGV4aXQgPSAweCV4XG4i
LCBpbmIoQUQxODQ4UChjaGlwLCBSRUdTRUwpKSk7DQo=

--289736052-2121362787-1190179362=:27377--