[alsa-devel] SALSA and aplay

[Takashi Iwai]

At Fri, 20 Jul 2007 12:57:07 +0100,
Alan Horstmann wrote:
> 
> On Thursday 19 July 2007 10:30, you wrote:
> > At Wed, 18 Jul 2007 16:01:11 +0100,
> >
> > Alan Horstmann wrote:
> > > Patching file pcm.c using Plan A...
> > > Hunk #1 succeeded at 284.
> > > Hunk #2 succeeded at 292.
> > > Hunk #3 succeeded at 333.
> > > Hunk #4 succeeded at 345.
> > > patch unexpectedly ends in middle of line
> > > Hunk #5 succeeded at 418.
> > > done
> > >
> > > With patch applied, the 'hebrew' is gone!
> >
> > Thanks for confirmation.  The patch was included in 0.0.8 release.
> 
> OK. Salsa is performing the same as asound using "hw", except one other 
> perhaps trivial thing I have noticed.  The aplay code does
> 	err = snd_output_stdio_attach(&log, stderr, 0);
> and prints things
> 	snd_pcm_hw_params_dump(params, log);
> finishing with
> 	snd_output_close(log)
> In alsa-lib, the third parameter of .._attach is used to set 'close', and 
> being 0, means stderr is not closed.  However, with salsa the file is always 
> closed at the end.  I am using the aplay code as a function, and on the 2nd 
> call, there are non of the print items.  Preventing this close in salsa or 
> the aplay code does remove the problem.  Is this intended trimming of 
> functionality for min size?

Ah, that stupid wrapper for FILE I/O.  I don't understand why such a
thing was introduced...

Not sure whether I'll fix it or leave it yet.

Takashi