[alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions

Adrian McMenamin adrianmcmenamin at gmail.com
Fri Jul 6 12:09:00 CEST 2007


On 06/07/07, Takashi Iwai <tiwai at suse.de> wrote:
> I guess you shoud call del_timer() there at least.  Otherwise the
> timer handler (aica_period_elapsed()) might be called even if the
> stream is not really running.
>

Fair enough. I'll fix that and repost later.

> The below is some coding style fixes, BTW.  I'm not sure whether
> queue_work() is intended in the block if "if (dma_check == 0)" or
> not.
>

It's just an aberrant indent - I think there was an independent block
there in earlier code, it got removed but the tab stayed :)


More information about the Alsa-devel mailing list