[alsa-devel] I2C fix for ice1724

Pavel Hofman pavel.hofman at insite.cz
Sat Dec 1 13:05:25 CET 2007


Hello Takashi,

Below is a patch for ice1724 I2C read code.


Thanks,

Pavel.


Signed-off-by: Pavel Hofman <dustin at seznam.cz>

* adding i2c busy wait before sending device address to prevent reading 
bogus data

diff -r 7f4b25ff79d6 pci/ice1712/ice1724.c
--- a/pci/ice1712/ice1724.c Fri Nov 30 17:59:25 2007 +0100
+++ b/pci/ice1712/ice1724.c Fri Nov 30 21:17:36 2007 +0100
@@ -1958,6 +1958,7 @@ unsigned char snd_vt1724_read_i2c(struct
         unsigned char val;

         mutex_lock(&ice->i2c_mutex);
+ wait_i2c_busy(ice);
         outb(addr, ICEREG1724(ice, I2C_BYTE_ADDR));
         outb(dev & ~VT1724_I2C_WRITE, ICEREG1724(ice, I2C_DEV_ADDR));
         wait_i2c_busy(ice);


More information about the Alsa-devel mailing list