[alsa-devel] [PATCH] ad1848-lib Makefile cleanup

Krzysztof Helt krzysztof.h1 at wp.pl
Thu Aug 9 20:03:22 CEST 2007


On Thu, 09 Aug 2007 19:21:44 +0200
Takashi Iwai <tiwai at suse.de> wrote:

> At Thu, 9 Aug 2007 19:06:43 +0200,
> Krzysztof Helt wrote:
> > 

> >  obj-$(CONFIG_SND_AD1848) += snd-ad1848.o snd-ad1848-lib.o
> 
> This line should contain only snd-ad1848.o.
> 
ok.

> > -obj-$(CONFIG_SND_OPTI92X_AD1848) += snd-ad1848-lib.o
> > +obj-$(CONFIG_SND_AD1848_LIB) += snd-ad1848-lib.o
> >  
> >  obj-m := $(sort $(obj-m))
> 
> Oh, this sort is also superfluous.
> 
> There need similar cleanups in other isa/* directories.
> Care to create a patch including them?
> 

Should this be one patch for all isa libs or each one in the separate patch?

Regards,
Krzysztof


More information about the Alsa-devel mailing list