[alsa-devel] [PATCH] Re: iec958 switch uneffective while playing ac3 stream
Takashi Iwai
tiwai at suse.de
Thu Apr 12 21:38:04 CEST 2007
At Thu, 12 Apr 2007 20:14:42 +0200,
Dominique Dumont wrote:
>
> Takashi Iwai <tiwai at suse.de> writes:
>
> > I prefer having options in snd-hda-intel side. Also, setting
> > permission 0644 makes it possible to turn on/off the debug option
> > dynamically, which is pretty useful.
>
> Agreed.
>
> > A test patch is below. How about it?
>
> Almost fine with me. The option name is a bit terse. A newbie (or an
> alsa hacker wanabee like me) might not know which command is involved
> just by reading the parameter name (trace_cmd).
>
> I'd rather have a slightly longer name like trace_codec_cmd
It sounds too long to me :)
Takashi
More information about the Alsa-devel
mailing list