[Sound-open-firmware] [PATCH] dma: dw-dma: fix wrong memory capabilities flags
From: Pan Xiuli xiuli.pan@linux.intel.com
Runtime heap does not support DMA, fix this bug.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com --- Test with: Mininow max rt5651 and GP-MRB with Nocodec SOF master: e92ef97834489f52c0f20445d401a8c6e0aaed62 SOF-Tool master: 5b8dfd13019cfd29999503b56c902f56209000ed https://github.com/plbossart/sound/tree/topic/sof-v4.14: d919ea06b7f79c95ab4eb68baf05e9faf3a894c1 --- src/drivers/dw-dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/drivers/dw-dma.c b/src/drivers/dw-dma.c index c2d6917..18e4583 100644 --- a/src/drivers/dw-dma.c +++ b/src/drivers/dw-dma.c @@ -552,9 +552,9 @@ static int dw_dma_set_config(struct dma *dma, int channel, /* allocate descriptors for channel */ if (p->chan[channel].lli) rfree(p->chan[channel].lli); - p->chan[channel].lli = rzalloc(RZONE_RUNTIME, - SOF_MEM_CAPS_RAM | SOF_MEM_CAPS_DMA, - sizeof(struct dw_lli2) * p->chan[channel].desc_count); + p->chan[channel].lli = rzalloc(RZONE_RUNTIME, SOF_MEM_CAPS_RAM, + sizeof(struct dw_lli2) * + p->chan[channel].desc_count); if (p->chan[channel].lli == NULL) { trace_dma_error("eD1"); ret = -ENOMEM;
On Tue, 2018-03-06 at 15:41 +0800, Xiuli Pan wrote:
From: Pan Xiuli xiuli.pan@linux.intel.com
Runtime heap does not support DMA, fix this bug.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com
Theses descriptors have to reside in DMA able memory. What's the issue here ?
Liam
participants (2)
-
Liam Girdwood
-
Xiuli Pan