Curtis Malainey | Chrome OS Audio Senior Software Engineer | cujomalainey@google.com | Sound Open Firmware Lead

On Fri, Oct 20, 2023 at 2:00 PM Mark Hasemeyer markhas@chromium.org wrote:

Some Chromebooks do not populate the product family DMI value resulting in firmware load failures.

Add another quirk detection entry that looks for "Google" in the BIOS version. Theoretically, PRODUCT_FAMILY could be replaced with BIOS_VERSION, but it is left as a quirk to be conservative.

Cc: stable@vger.kernel.org Signed-off-by: Mark Hasemeyer markhas@chromium.org

Acked-by: Curtis Malainey cujomalainey@chromium.org

---

sound/soc/sof/sof-pci-dev.c | 7 +++++++ 1 file changed, 7 insertions(+)

diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c index 1d706490588e..64b326e3ef85 100644 --- a/sound/soc/sof/sof-pci-dev.c +++ b/sound/soc/sof/sof-pci-dev.c @@ -145,6 +145,13 @@ static const struct dmi_system_id community_key_platforms[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), } },

•   {
  

•           .ident = "Google firmware",
  

•           .callback = chromebook_use_community_key,
  

•           .matches = {
  

•                   DMI_MATCH(DMI_BIOS_VERSION, "Google"),
  

•           }
  

•   },
    {},
  

};

-- 2.42.0.655.g421f12c284-goog