[Sound-open-firmware] [PATCH] Change type of size in trace_work() callback from uint32_t to int32_t.
From: Yan Wang yan.wang@linux.intel.com
This variable is set by the return value of dma_copy_to_host_nowait(). Unsigned type will mislead error checking.
Signed-off-by: Yan Wang yan.wang@linux.intel.com --- src/lib/dma-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/dma-trace.c b/src/lib/dma-trace.c index ea63ab4..1fbd050 100644 --- a/src/lib/dma-trace.c +++ b/src/lib/dma-trace.c @@ -48,7 +48,7 @@ static uint64_t trace_work(void *data, uint64_t delay) struct dma_sg_config *config = &d->config; unsigned long flags; uint32_t avail = buffer->avail; - uint32_t size; + int32_t size; uint32_t hsize; uint32_t lsize;
On Wed, 2017-12-20 at 15:45 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
This variable is set by the return value of dma_copy_to_host_nowait(). Unsigned type will mislead error checking.
Signed-off-by: Yan Wang yan.wang@linux.intel.com
src/lib/dma-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/dma-trace.c b/src/lib/dma-trace.c index ea63ab4..1fbd050 100644 --- a/src/lib/dma-trace.c +++ b/src/lib/dma-trace.c @@ -48,7 +48,7 @@ static uint64_t trace_work(void *data, uint64_t delay) struct dma_sg_config *config = &d->config; unsigned long flags; uint32_t avail = buffer->avail;
- uint32_t size;
- int32_t size; uint32_t hsize; uint32_t lsize;
Applied.
participants (2)
-
Liam Girdwood -
yan.wang＠linux.intel.com