Hello all,

This is a follow up of email thread started [1].

My major request in the first email was for the commit message to explain WHY the change is needed.

Things are looking good! Patches are easier to review and understand. This will also help newcomers trying to understand the code and contribute.

Next request:

Better split of the code into separate patches. Please create a patch for each logical change.

Do not put small fixes (e.g whitespaces, tabs, code removal) together with a bigger patch. Just create a separate patch.

Make sure each individual patch compiles so that we don't break bisection!

Thanks, Daniel.

[1] https://mailman.alsa-project.org/pipermail/sound-open-firmware/2019-May/0033...