[Sound-open-firmware] revised SOF ABI change process now in effect
Hi all,
we’ve been working on some improvements to the SOF ABI change process since April this year, to address some of the issues seen in pull-req reviews at start of this year. The problem statement and resulting discussing can be seen at:
https://github.com/orgs/thesofproject/teams/sof-developers/discussions/35 https://github.com/thesofproject/sof-docs/pull/244
The new process is now in effect and documented at: https://thesofproject.github.io/latest/contribute/process/abiprocess.html
The main changes: - the process is now documented in sof-docs with a diagram - a new RFC step to discuss the interface before implementation is done - driver PR is no longer mandatory to be done at same time (but depends on type of change) - when driver+FW changes are both needed, driver change must be merged first
Br, Kai
On 29/06/20 8:28 pm, Kai Vehmanen wrote:
we’ve been working on some improvements to the SOF ABI change process since April this year, to address some of the issues seen in pull-req reviews at start of this year. The problem statement and resulting discussing can be seen at:
https://github.com/orgs/thesofproject/teams/sof-developers/discussions/35
This link seems to be broken. Can you please look into this?
thanks, ymdatta.
On Tue, Jun 30, 2020 at 9:09 PM ymdatta ymdatta.work@gmail.com wrote:
On 29/06/20 8:28 pm, Kai Vehmanen wrote:
we’ve been working on some improvements to the SOF ABI change process since April this year, to address some of the issues seen in pull-req reviews at start of this year. The problem statement and resulting discussing can be seen at:
https://github.com/orgs/thesofproject/teams/sof-developers/discussions/35
This link seems to be broken. Can you please look into this?
The link is good, it's just not public. You can view the results of the conversation here.
@Liam can we add ymdatta to sof-developers? They are working on the fuzzer and it would be a good place to ask for info on blockers.
thanks, ymdatta.
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Tue, 2020-06-30 at 23:43 -0700, Curtis Malainey wrote:
On Tue, Jun 30, 2020 at 9:09 PM ymdatta ymdatta.work@gmail.com wrote:
On 29/06/20 8:28 pm, Kai Vehmanen wrote:
we’ve been working on some improvements to the SOF ABI change process since April this year, to address some of the issues seen in pull-req reviews at start of this year. The problem statement and resulting discussing can be seen at:
https://github.com/orgs/thesofproject/teams/sof-developers/discussions/35
This link seems to be broken. Can you please look into this?
The link is good, it's just not public. You can view the results of the conversation here.
@Liam can we add ymdatta to sof-developers? They are working on the fuzzer and it would be a good place to ask for info on blockers.
Sorry, ymdatta - I thought you were already a member. Now done, you should see and invite in your inbox.
Thanks
Liam
thanks, ymdatta.
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On 01/07/20 2:39 pm, Girdwood, Liam R wrote:
On Tue, 2020-06-30 at 23:43 -0700, Curtis Malainey wrote:
On Tue, Jun 30, 2020 at 9:09 PM ymdatta ymdatta.work@gmail.com wrote:
On 29/06/20 8:28 pm, Kai Vehmanen wrote:
Sorry, ymdatta - I thought you were already a member. Now done, you should see and invite in your inbox.
No problem and thanks Liam, now i am able to view the discussions.
thanks, ymdatta.
Whoops forgot to post the public link, will post here for the record. https://thesofproject.github.io/latest/contribute/process/abiprocess.html
On Wed, Jul 1, 2020 at 2:20 AM ymdatta ymdatta.work@gmail.com wrote:
On 01/07/20 2:39 pm, Girdwood, Liam R wrote:
On Tue, 2020-06-30 at 23:43 -0700, Curtis Malainey wrote:
On Tue, Jun 30, 2020 at 9:09 PM ymdatta ymdatta.work@gmail.com wrote:
On 29/06/20 8:28 pm, Kai Vehmanen wrote:
Sorry, ymdatta - I thought you were already a member. Now done, you should see and invite in your inbox.
No problem and thanks Liam, now i am able to view the discussions.
thanks, ymdatta.
Hey,
On Wed, 1 Jul 2020, Curtis Malainey wrote:
Whoops forgot to post the public link, will post here for the record. https://thesofproject.github.io/latest/contribute/process/abiprocess.html
thanks Curtis! And yeah, the GH discussions tool is open to all project members, so I'd expect all people submitting patches to have access the GH discussions. At least my intention was to reach all devs from the start.
As for the ABI process -- it is still a very lightweight one and it will be easy to adjust if and when issues are found. So even if you missed this review round, don't hesitate to give feedback.
Br, Kai
participants (4)
-
Curtis Malainey -
Girdwood, Liam R -
Kai Vehmanen -
ymdatta