[Sound-open-firmware] why we define the MACRO's value like this below
Hello Liam:
I found in the header file "component.h",
the macro value defined below show like below, Is there any tricky thing we have to do like this below?
The "COMP_TRIGGER_RESUME" and "COMP_TRIGGER_RESET" use the same value.
And "4" is not used.
I did not find out the reason why define it like this below.
Is it a typo error?
#define COMP_TRIGGER_STOP 0 /* stop component stream */ #define COMP_TRIGGER_START 1 /* start component stream */ #define COMP_TRIGGER_PAUSE 2 /* pause the component stream */ #define COMP_TRIGGER_RELEASE 3 /* release paused component stream */ #define COMP_TRIGGER_SUSPEND 5 /* suspend component */ #define COMP_TRIGGER_RESUME 6 /* resume component */ #define COMP_TRIGGER_RESET 6 /* reset component */ #define COMP_TRIGGER_PREPARE 7 /* prepare component */ #define COMP_TRIGGER_XRUN 8 /* XRUN component */
thanks
br
~zhigang
On 2018年06月04日 14:20, zhigangw wrote:
Hello Liam:
I found in the header file "component.h",
the macro value defined below show like below, Is there any tricky thing we have to do like this below?
The "COMP_TRIGGER_RESUME" and "COMP_TRIGGER_RESET" use the same value.
And "4" is not used.
I did not find out the reason why define it like this below.
Is it a typo error?
#define COMP_TRIGGER_STOP 0 /* stop component stream */ #define COMP_TRIGGER_START 1 /* start component stream */ #define COMP_TRIGGER_PAUSE 2 /* pause the component stream */ #define COMP_TRIGGER_RELEASE 3 /* release paused component stream */ #define COMP_TRIGGER_SUSPEND 5 /* suspend component */ #define COMP_TRIGGER_RESUME 6 /* resume component */ #define COMP_TRIGGER_RESET 6 /* reset component */
Yes, it's definitely a typo here, Zhigang, can you send a patch to fix it?
Thanks, ~Keyon
#define COMP_TRIGGER_PREPARE 7 /* prepare component */ #define COMP_TRIGGER_XRUN 8 /* XRUN component */
thanks
br
~zhigang
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On 2018年06月04日 14:33, Keyon Jie wrote:
On 2018年06月04日 14:20, zhigangw wrote:
Hello Liam:
I found in the header file "component.h",
the macro value defined below show like below, Is there any tricky thing we have to do like this below?
The "COMP_TRIGGER_RESUME" and "COMP_TRIGGER_RESET" use the same value.
And "4" is not used.
I did not find out the reason why define it like this below.
Is it a typo error?
#define COMP_TRIGGER_STOP 0 /* stop component stream */ #define COMP_TRIGGER_START 1 /* start component stream */ #define COMP_TRIGGER_PAUSE 2 /* pause the component stream */ #define COMP_TRIGGER_RELEASE 3 /* release paused component stream */ #define COMP_TRIGGER_SUSPEND 5 /* suspend component */ #define COMP_TRIGGER_RESUME 6 /* resume component */ #define COMP_TRIGGER_RESET 6 /* reset component */
Yes, it's definitely a typo here, Zhigang, can you send a patch to fix it?
Thanks, ~Keyon
Yes, I will. thanks br ~zhigang
#define COMP_TRIGGER_PREPARE 7 /* prepare component */ #define COMP_TRIGGER_XRUN 8 /* XRUN component */
thanks
br
~zhigang
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
participants (2)
-
Keyon Jie -
zhigangw