On Wed, Apr 16, 2025 at 03:12:11PM +0200, Philipp Stanner wrote:

pci_request_regions() is a hybrid function which becomes managed if pcim_enable_device() was called before. This hybrid nature is deprecated and should not be used anymore.

Replace pci_request_regions() with the always-managed function pcim_request_all_regions().

Remove surplus calls to PCI release functions, since pcim_ functions do cleanup automatically.

...

ret = snd_sof_device_probe(dev, sof_pdata);

-out:

• if (ret)

• pci_release_regions(pci);
  

• return ret;

Obviously you can go further

return snd_sof_...(...);