[Sound-open-firmware] [PATCH] host-gw: fix hda-dma not start at pause release issue.
We don't need stop host dma at pause, which is aligned with baytrail GPDMA.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com --- src/audio/host.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/audio/host.c b/src/audio/host.c index 9177d99..ac79d36 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -465,9 +465,6 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) return ret;
switch (cmd) { - case COMP_CMD_PAUSE: - dma_stop(hd->dma, hd->chan); - break; case COMP_CMD_STOP: ret = host_stop(dev); break;
On Thu, 2018-03-29 at 19:11 +0800, Keyon Jie wrote:
We don't need stop host dma at pause, which is aligned with baytrail GPDMA.
Updated to new trigger API and applied.
Thanks
Liam
On 3/29/2018 19:11, Keyon Jie wrote:
We don't need stop host dma at pause, which is aligned with baytrail GPDMA.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
src/audio/host.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/audio/host.c b/src/audio/host.c index 9177d99..ac79d36 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -465,9 +465,6 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) return ret;
switch (cmd) {
- case COMP_CMD_PAUSE:
dma_stop(hd->dma, hd->chan);
break;
These code is added here to avoid. Host DMA start status check fail. Now we won't see Host DMA start fail?
Thanks Xiuli
case COMP_CMD_STOP: ret = host_stop(dev); break;
-----Original Message----- From: Pan, Xiuli [mailto:xiuli.pan@linux.intel.com] Sent: Thursday, March 29, 2018 10:05 PM To: Keyon Jie yang.jie@linux.intel.com; sound-open-firmware@alsa-project.org Cc: Jie, Yang yang.jie@intel.com Subject: Re: [Sound-open-firmware] [PATCH] host-gw: fix hda-dma not start at pause release issue.
On 3/29/2018 19:11, Keyon Jie wrote:
We don't need stop host dma at pause, which is aligned with baytrail GPDMA.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com
src/audio/host.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/audio/host.c b/src/audio/host.c index 9177d99..ac79d36 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -465,9 +465,6 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) return ret;
switch (cmd) {
- case COMP_CMD_PAUSE:
dma_stop(hd->dma, hd->chan);
break;
These code is added here to avoid. Host DMA start status check fail. Now we won't see Host DMA start fail?
Thanks Xiuli
[Keyon] are you meaning the normal start no pause/release?
Thanks, ~Keyon
case COMP_CMD_STOP: ret = host_stop(dev); break;
participants (4)
-
Jie, Yang
-
Keyon Jie
-
Liam Girdwood
-
Pan, Xiuli