Hi Daniel,

On Thu, 2022-04-07 at 15:27 +0100, Daniel Golle wrote:

On Thu, Apr 07, 2022 at 09:03:37PM +0800, Allen-KH Cheng wrote:

...

This patch provides mediatek adsp ipc support for SOF. ADSP IPC protocol offers (send/recv) interfaces using mediatek-mailbox APIs.

This patch was tested and confirmed to with SOF fw on MT8195 cherry board.

... confirmed to **work** with ... is probably what you meant to write here.

Yes, thanks for your reminder.

It appears that for some reason I forgot to add this part.

We had tested ADSP IPC protocol with SOF in github.com/thesofproject/sof/tree/mt8195/v0.4.

The other mailbox control is patchwork.kernel.org/patch/12728222/

Thanks, Allen

...

Based on matthias.bgg/linux.git, v5.18-next/soc changes since v6:

• rebase to matthias.bgg/linux.git, v5.18-next/soc
• Prefer "GPL" over "GPL v2" for MODULE_LICENSE

changes since v5:

• fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line.
• Due to WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 in checkpatch, we don't remove SPDX-License in line 1.

changes since v4:

• add error message for wrong mbox chan

changes since v3:

• rebase on v5.16-rc8
• update reviewers

changes since v2:

• add out tag for two memory free phases

changes since v1:

• add comments for mtk_adsp_ipc_send and mtk_adsp_ipc_recv
• remove useless MODULE_LICENSE
• change label name to out_free

Allen-KH Cheng (1): firmware: mediatek: add adsp ipc protocol interface

drivers/firmware/Kconfig | 1 + drivers/firmware/Makefile | 1 + drivers/firmware/mediatek/Kconfig | 9 + drivers/firmware/mediatek/Makefile | 2 + drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ 6 files changed, 239 insertions(+) create mode 100644 drivers/firmware/mediatek/Kconfig create mode 100644 drivers/firmware/mediatek/Makefile create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h

-- 2.18.0