[Sound-open-firmware] [PATCH] topology: byt-rt5640: Fix DAI config
DAI config was coming from deprecated machine driver. Fix it to use bytcr-rt5640 machine driver.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com --- topology/reef-byt-rt5640.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 879e9a9..bf2b004 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -1,5 +1,5 @@ # -# Topology for generic Baytrail board with no codec. +# Topology for generic Baytrail board with no RT5640. #
# Include topology builder @@ -76,7 +76,7 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-playback.m4, - 1, SSP, 2, SSP-Codec + 1, SSP, 2, SSP-Codec, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0)
@@ -93,7 +93,7 @@ PCM_DUPLEX_ADD(Low Latency, 6, 0, 0, PIPELINE_PCM_1, PIPELINE_PCM_2) # # BE configurations - overrides config in ACPI if present # -DAI_CONFIG(SSP, 2, Baytrail Audio, I2S, 24, +DAI_CONFIG(SSP, 2, SSP2-Codec, I2S, 24, DAI_CLOCK(mclk, 19200000, slave), DAI_CLOCK(bclk, 2400000, slave), DAI_CLOCK(fsync, 48000, slave),
On 03/15/2018 04:20 PM, Liam Girdwood wrote:
DAI config was coming from deprecated machine driver. Fix it to use bytcr-rt5640 machine driver.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com
topology/reef-byt-rt5640.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 879e9a9..bf2b004 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -1,5 +1,5 @@ # -# Topology for generic Baytrail board with no codec. +# Topology for generic Baytrail board with no RT5640. #
# Include topology builder @@ -76,7 +76,7 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-playback.m4,
- 1, SSP, 2, SSP-Codec
- 1, SSP, 2, SSP-Codec,
Could it also be that it's SSP2-Codec in all those files? That might explain the issue I have with DAI configs...
PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0)
@@ -93,7 +93,7 @@ PCM_DUPLEX_ADD(Low Latency, 6, 0, 0, PIPELINE_PCM_1, PIPELINE_PCM_2) # # BE configurations - overrides config in ACPI if present # -DAI_CONFIG(SSP, 2, Baytrail Audio, I2S, 24, +DAI_CONFIG(SSP, 2, SSP2-Codec, I2S, 24, DAI_CLOCK(mclk, 19200000, slave), DAI_CLOCK(bclk, 2400000, slave), DAI_CLOCK(fsync, 48000, slave),
On 03/15/2018 04:33 PM, Pierre-Louis Bossart wrote:
On 03/15/2018 04:20 PM, Liam Girdwood wrote:
DAI config was coming from deprecated machine driver. Fix it to use bytcr-rt5640 machine driver.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com
topology/reef-byt-rt5640.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 879e9a9..bf2b004 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -1,5 +1,5 @@ # -# Topology for generic Baytrail board with no codec. +# Topology for generic Baytrail board with no RT5640. # # Include topology builder @@ -76,7 +76,7 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-playback.m4, - 1, SSP, 2, SSP-Codec + 1, SSP, 2, SSP-Codec,
Could it also be that it's SSP2-Codec in all those files? That might explain the issue I have with DAI configs...
Actually should be SSP2-Codec here, all the other files have this. Still doesn't tell me what's wrong with those files.
PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) @@ -93,7 +93,7 @@ PCM_DUPLEX_ADD(Low Latency, 6, 0, 0, PIPELINE_PCM_1, PIPELINE_PCM_2) # # BE configurations - overrides config in ACPI if present # -DAI_CONFIG(SSP, 2, Baytrail Audio, I2S, 24, +DAI_CONFIG(SSP, 2, SSP2-Codec, I2S, 24, DAI_CLOCK(mclk, 19200000, slave), DAI_CLOCK(bclk, 2400000, slave), DAI_CLOCK(fsync, 48000, slave),
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Thu, 2018-03-15 at 16:37 -0500, Pierre-Louis Bossart wrote:
On 03/15/2018 04:33 PM, Pierre-Louis Bossart wrote:
On 03/15/2018 04:20 PM, Liam Girdwood wrote:
DAI config was coming from deprecated machine driver. Fix it to use bytcr-rt5640 machine driver.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com
topology/reef-byt-rt5640.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 879e9a9..bf2b004 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -1,5 +1,5 @@ # -# Topology for generic Baytrail board with no codec. +# Topology for generic Baytrail board with no RT5640. # # Include topology builder @@ -76,7 +76,7 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-playback.m4,
- 1, SSP, 2, SSP-Codec
- 1, SSP, 2, SSP-Codec,
Could it also be that it's SSP2-Codec in all those files? That might explain the issue I have with DAI configs...
Actually should be SSP2-Codec here, all the other files have this. Still doesn't tell me what's wrong with those files.
Your right, now fixed. I've been thinking maybe qemu is the best way to test all these (without the HW) since qemu can virtualise all the codecs as dummy devices....
Liam
participants (2)
-
Liam Girdwood -
Pierre-Louis Bossart