Thanks for the review Mark

On 4/19/19 10:54 AM, Mark Brown wrote:

On Fri, Apr 12, 2019 at 11:05:08AM -0500, Pierre-Louis Bossart wrote:

...

• if (pm_runtime_active(sdev->dev) ||
  

•     dfse->access_type == SOF_DEBUGFS_ACCESS_ALWAYS) {
  

• 	memcpy_fromio(buf, dfse->io_mem + pos, size);
  

• } else {
  

• 	dev_info(sdev->dev,
  

• 		 "Copying cached debugfs data\n");
  

• 	memcpy(buf, dfse->cache_buf + pos, size);
  

• }
  

Might this get a bit noisy if we start hitting the info case?

Indeed, I recall we discussed removing this log but it's still there. We can fix this with a follow-up patch or in a v7 depending if there are other comments.