[Sound-open-firmware] [PATCH v2] topology:scripts: fix tplg build script to compile last topology when using xargs
When using xargs, the last topology file while batch processing alsatplg doesn't get compiled properly.
It also removes a stray ; in the script.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com --- topology/test/tplg-build.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/topology/test/tplg-build.sh b/topology/test/tplg-build.sh index 26c70ad..af23b66 100755 --- a/topology/test/tplg-build.sh +++ b/topology/test/tplg-build.sh @@ -157,12 +157,14 @@ simple_test codec tone "SSP2-Codec" s32le 2 s16le 20 16 1920000 19200000 I2S TON if [ "$USE_XARGS" == "yes" ] then echo "Batch processing m4 files..." - M4_STRINGS=${M4_STRINGS%?}; + M4_STRINGS=${M4_STRINGS%?} #m4 processing echo $M4_STRINGS | tr " " "," | tr '\n' '\0' | xargs -P0 -d ',' -n12 bash -c 'm4 "${@:1:${#}-1}" > ${12}.conf' m4
#execute alsatplg to create topology binary TEST_STRINGS=${TEST_STRINGS%?} - echo $TEST_STRINGS | tr '\n' '\0' | xargs -d ',' -P0 -n1 -I string alsatplg -v 1 -c string".conf" -o string".tplg" + echo $TEST_STRINGS | tr '\n' ',' |\ + xargs -d ',' -P0 -n1 -I string alsatplg -v 1 -c\ + string".conf" -o string".tplg" fi
On Sat, 2018-05-26 at 22:58 -0700, Ranjani Sridharan wrote:
When using xargs, the last topology file while batch processing alsatplg doesn't get compiled properly.
It also removes a stray ; in the script.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com
Applied.
Thanks
Liam
On Mon, 2018-05-28 at 14:48 +0100, Liam Girdwood wrote:
On Sat, 2018-05-26 at 22:58 -0700, Ranjani Sridharan wrote:
When using xargs, the last topology file while batch processing alsatplg doesn't get compiled properly.
It also removes a stray ; in the script.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com
Applied.
Liam, I see that this patch is still not in master?
Thanks
Liam _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Thu, 2018-05-31 at 09:08 -0700, Ranjani Sridharan wrote:
On Mon, 2018-05-28 at 14:48 +0100, Liam Girdwood wrote:
On Sat, 2018-05-26 at 22:58 -0700, Ranjani Sridharan wrote:
When using xargs, the last topology file while batch processing alsatplg doesn't get compiled properly.
It also removes a stray ; in the script.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.c om
Applied.
Liam, I see that this patch is still not in master?
Sorry my bad! its there. Please ignore.
Thanks
Liam _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmwar e
participants (2)
-
Liam Girdwood
-
Ranjani Sridharan