[Sound-open-firmware] [PATCH] Use tracev instead of trace for dai irq event.
From: Yan Wang <yan.wang@linux.intel.com> This event is in pipeline and will produce many trace data in a short time. It should use tracev to disable it by default. Signed-off-by: Yan Wang <yan.wang@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> --- Test with: Mininow max rt5651 and APL UP^2 nocodec and CNL nocodec SOF 1.1-stable: 7f9110c4c0ca26a67e0e4baa91e5f0bcc31a1c3e SOF-Tool 1.1-stable: 99c09871a85111e52d4fa68a4d6f96770d1aabbd https://github.com/plbossart/sound/tree/topic/sof-v4.14: c33cfed51fff5eb156dcf70ba849e6ffb3008377 --- src/audio/dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/audio/dai.c b/src/audio/dai.c index 1383c14..0a96ee1 100644 --- a/src/audio/dai.c +++ b/src/audio/dai.c @@ -79,7 +79,7 @@ static void dai_dma_cb(void *data, uint32_t type, struct dma_sg_elem *next) struct dai_data *dd = comp_get_drvdata(dev); struct comp_buffer *dma_buffer; - trace_dai("irq"); + tracev_dai("irq"); /* stop dma copy for pause/stop/xrun */ if (dev->state != COMP_STATE_ACTIVE || dd->xrun) { -- 2.14.3
On Mon, 2018-04-02 at 10:51 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang <yan.wang@linux.intel.com>
This event is in pipeline and will produce many trace data in a short time. It should use tracev to disable it by default.
Signed-off-by: Yan Wang <yan.wang@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Applied. The intention for trace is the pipeline/component copy() and IRQ trace messages should be verbose due their high frequency. In 1.2 I'd like to see a debugFS file that can enable/disable trace and verbose trace per subsystem/component at runtime. e.g. echo off > /sys/kernel/debug/sof/trace_level echo on > /sys/kernel/debug/sof/trace_level echo src > /sys/kernel/debug/sof/trace_level echo pipeline > /sys/kernel/debug/sof/trace_level echo scheduler > /sys/kernel/debug/sof/trace_level Liam --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On 4/2/2018 5:25 PM, Liam Girdwood wrote:
On Mon, 2018-04-02 at 10:51 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang <yan.wang@linux.intel.com>
This event is in pipeline and will produce many trace data in a short time. It should use tracev to disable it by default.
Signed-off-by: Yan Wang <yan.wang@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Applied. The intention for trace is the pipeline/component copy() and IRQ trace messages should be verbose due their high frequency.
In 1.2 I'd like to see a debugFS file that can enable/disable trace and verbose trace per subsystem/component at runtime.
e.g.
echo off > /sys/kernel/debug/sof/trace_level echo on > /sys/kernel/debug/sof/trace_level echo src > /sys/kernel/debug/sof/trace_level echo pipeline > /sys/kernel/debug/sof/trace_level echo scheduler > /sys/kernel/debug/sof/trace_level
Sure. I can try to implement it. Thanks. Yan Wang
Liam --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
participants (3)
-
Liam Girdwood -
Yan Wang -
yan.wang＠linux.intel.com