[Sound-open-firmware] [PATCH] Disable high frequent trace message in dw_dma_irq_handler().
From: Yan Wang yan.wang@linux.intel.com
It will cause DMA trace local buffer overflow and unnecessary.
Signed-off-by: Yan Wang yan.wang@linux.intel.com --- src/drivers/dw-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/drivers/dw-dma.c b/src/drivers/dw-dma.c index a5717f3..2c46545 100644 --- a/src/drivers/dw-dma.c +++ b/src/drivers/dw-dma.c @@ -910,11 +910,12 @@ static void dw_dma_irq_handler(void *data) int i = dma_int->channel;
status_intr = dw_read(dma, DW_INTR_STATUS); - if (!status_intr) + if (!status_intr) { trace_dma_error("eDI"); + trace_value(status_intr); + }
- trace_dma("irq"); - trace_value(status_intr); + tracev_dma("irq");
/* get the source of our IRQ. */ status_block = dw_read(dma, DW_STATUS_BLOCK);
On 3/20/18 3:09 AM, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
It will cause DMA trace local buffer overflow and unnecessary.
it feels like it's time to add trace_ratelimited?
Signed-off-by: Yan Wang yan.wang@linux.intel.com
src/drivers/dw-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/drivers/dw-dma.c b/src/drivers/dw-dma.c index a5717f3..2c46545 100644 --- a/src/drivers/dw-dma.c +++ b/src/drivers/dw-dma.c @@ -910,11 +910,12 @@ static void dw_dma_irq_handler(void *data) int i = dma_int->channel;
status_intr = dw_read(dma, DW_INTR_STATUS);
- if (!status_intr)
- if (!status_intr) { trace_dma_error("eDI");
trace_value(status_intr);- }
- trace_dma("irq");
- trace_value(status_intr);
tracev_dma("irq");
/* get the source of our IRQ. */ status_block = dw_read(dma, DW_STATUS_BLOCK);
-----Original Message----- From: sound-open-firmware-bounces@alsa-project.org [mailto:sound-open- firmware-bounces@alsa-project.org] On Behalf Of Pierre-Louis Bossart Sent: Tuesday, March 20, 2018 10:49 PM To: yan.wang@linux.intel.com; sound-open-firmware@alsa-project.org Subject: Re: [Sound-open-firmware] [PATCH] Disable high frequent trace message in dw_dma_irq_handler().
On 3/20/18 3:09 AM, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
It will cause DMA trace local buffer overflow and unnecessary.
it feels like it's time to add trace_ratelimited?
This will make me miss the traditional mailbox trace more. :-)
Thanks, ~Keyon
Signed-off-by: Yan Wang yan.wang@linux.intel.com
src/drivers/dw-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/drivers/dw-dma.c b/src/drivers/dw-dma.c index a5717f3..2c46545 100644 --- a/src/drivers/dw-dma.c +++ b/src/drivers/dw-dma.c @@ -910,11 +910,12 @@ static void dw_dma_irq_handler(void *data) int i = dma_int->channel;
status_intr = dw_read(dma, DW_INTR_STATUS);
- if (!status_intr)
- if (!status_intr) { trace_dma_error("eDI");
trace_value(status_intr);- }
- trace_dma("irq");
- trace_value(status_intr);
tracev_dma("irq");
/* get the source of our IRQ. */ status_block = dw_read(dma, DW_STATUS_BLOCK);
Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Tue, 2018-03-20 at 14:51 +0000, Jie, Yang wrote:
On 3/20/18 3:09 AM, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
It will cause DMA trace local buffer overflow and unnecessary.
it feels like it's time to add trace_ratelimited?
This will make me miss the traditional mailbox trace more. :-)
It's not gone. It's used to store errors, but feel free to send a patch to trace.h that allows non error trace to also be sent to mailbox depending on a macro value.
Liam --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On Tue, 2018-03-20 at 18:09 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
It will cause DMA trace local buffer overflow and unnecessary.
Signed-off-by: Yan Wang yan.wang@linux.intel.com
Applied.
Thanks
Liam
participants (5)
-
Jie, Yang -
Liam Girdwood -
Liam Girdwood -
Pierre-Louis Bossart -
yan.wang＠linux.intel.com