[Sound-open-firmware] [PATCH] Fix timer on CNL.
From: Yan Wang yan.wang@linux.intel.com
Work queue cannot work rightly because it uses wrong timer setting. Based on Keyon's comments, use SSP CLK intead of CPU CLK. It is confirmed on my CNL platform.
Signed-off-by: Yan Wang yan.wang@linux.intel.com --- src/platform/cannonlake/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/platform/cannonlake/platform.c b/src/platform/cannonlake/platform.c index c49dcb8..c9449ed 100644 --- a/src/platform/cannonlake/platform.c +++ b/src/platform/cannonlake/platform.c @@ -129,8 +129,8 @@ static struct work_queue_timesource platform_generic_queue = { .id = TIMER3, /* external timer */ .irq = IRQ_EXT_TSTAMP0_LVL2(0), }, - .clk = CLK_CPU, - .notifier = NOTIFIER_ID_CPU_FREQ, + .clk = CLK_SSP, + .notifier = NOTIFIER_ID_SSP_FREQ, .timer_set = platform_timer_set, .timer_clear = platform_timer_clear, .timer_get = platform_timer_get,
On 2018年03月09日 15:27, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
Work queue cannot work rightly because it uses wrong timer setting. Based on Keyon's comments, use SSP CLK intead of CPU CLK. It is confirmed on my CNL platform.
Signed-off-by: Yan Wang yan.wang@linux.intel.com
Acked.
Thanks, ~Keyon
src/platform/cannonlake/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/platform/cannonlake/platform.c b/src/platform/cannonlake/platform.c index c49dcb8..c9449ed 100644 --- a/src/platform/cannonlake/platform.c +++ b/src/platform/cannonlake/platform.c @@ -129,8 +129,8 @@ static struct work_queue_timesource platform_generic_queue = { .id = TIMER3, /* external timer */ .irq = IRQ_EXT_TSTAMP0_LVL2(0), },
- .clk = CLK_CPU,
- .notifier = NOTIFIER_ID_CPU_FREQ,
- .clk = CLK_SSP,
- .notifier = NOTIFIER_ID_SSP_FREQ, .timer_set = platform_timer_set, .timer_clear = platform_timer_clear, .timer_get = platform_timer_get,
On Fri, 2018-03-09 at 15:27 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
Work queue cannot work rightly because it uses wrong timer setting. Based on Keyon's comments, use SSP CLK intead of CPU CLK. It is confirmed on my CNL platform.
Signed-off-by: Yan Wang yan.wang@linux.intel.com
Applied, but I've reworded the subject to :-
cnl: timer: Use SSP time source on CNL for workqueue.
In the future can you prefix the subject with platform: subsystem:
Thanks
Liam
On Fri, 2018-03-09 at 08:42 +0000, Liam Girdwood wrote:
On Fri, 2018-03-09 at 15:27 +0800, yan.wang@linux.intel.com wrote:
From: Yan Wang yan.wang@linux.intel.com
Work queue cannot work rightly because it uses wrong timer setting. Based on Keyon's comments, use SSP CLK intead of CPU CLK. It is confirmed on my CNL platform.
Signed-off-by: Yan Wang yan.wang@linux.intel.com
Applied, but I've reworded the subject to :-
cnl: timer: Use SSP time source on CNL for workqueue.
In the future can you prefix the subject with platform: subsystem:
Hi, Liam, Thanks for your help. I will add prefix in the future. Thanks.
Yan Wang
Thanks
Liam _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
participants (4)
-
Keyon Jie
-
Liam Girdwood
-
yan.wang@linux.intel.com
-
yanwang