On 04/04/2024 10:38, Dan Carpenter wrote:

The permissions on this debugfs file are 0444 so it can't be written to. And writing to the file hasn't done anything since commit 6e9548cdb30e ("ASoC: SOF: Convert the generic IPC flood test into SOF client"). Delete the write function.

I agree, it is not used anymore and ...

Signed-off-by: Dan Carpenter dan.carpenter@linaro.org

Acked-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com

---

I haven't tested this patch and there is a risk that it breaks some of the test scripts. Another option would be to just make it a dummy function that does { return count; }. But I thought I would try the better option first.

Please review this extra carefully.

sound/soc/sof/debug.c | 19 ------------------- 1 file changed, 19 deletions(-)

diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c index 7c8aafca8fde..937e51b02a24 100644 --- a/sound/soc/sof/debug.c +++ b/sound/soc/sof/debug.c @@ -19,24 +19,6 @@ #include "sof-priv.h" #include "ops.h"

-static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,

• 		  size_t count, loff_t *ppos)
  

-{

• size_t size;
• char *string;
• int ret;
• string = kzalloc(count+1, GFP_KERNEL);
• if (!string)

• return -ENOMEM;
  

• size = simple_write_to_buffer(string, count, ppos, buffer, count);
• ret = size;
• kfree(string);

This was not too constructive ;)

• return ret;

-}

static ssize_t sof_dfsentry_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { @@ -126,7 +108,6 @@ static const struct file_operations sof_dfs_fops = { .open = simple_open, .read = sof_dfsentry_read, .llseek = default_llseek,

• .write = sof_dfsentry_write,

};

/* create FS entry for debug files that can expose DSP memories, registers */