On Mon, 2017-08-07 at 19:26 -0500, Pierre-Louis Bossart wrote:

On 8/3/17 3:08 PM, Curtis Malainey wrote:

...

Minor debugging issue, when verbose trace is turned on it will not compile because these variables are incorrect.

Thank you for the fix.

Small nitpick: I believe we have an undocumented expectation to follow the kernel usages and ask for a Signed-off-by certificate of origin (see Documentation/SubmittingPatches), so if you could resubmit with the --signoff option it'd be great. It's overkill for this small fix I know but let's do the right thing from day1.

Liam, is this something we can add to the public wiki?

Yes, will do. Sorry, apologies I've not had much time this week to review patches with getting 1.0-rc1 ready...

Thanks

Liam

...

---

src/audio/eq_fir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index ae87f92..41c6d38 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -323,9 +323,9 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) fir_update, PLATFORM_MAX_CHANNELS);

/* Print trace information */

• tracev_value(iir_update->stream_max_channels);
  

• tracev_value(fir_update->stream_max_channels);
  

  for (i = 0; i < fir_update->stream_max_channels; i++)

• 	tracev_value(iir_update->assign_response[i]);
  

• 	tracev_value(fir_update->assign_response[i]);
  
  

  break; case COMP_CMD_EQ_FIR_CONFIG:

---

Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware

Yep, you are more than welcome to.

Curtis

On Wed, Aug 9, 2017 at 8:22 AM, Liam Girdwood liam.r.girdwood@intel.com wrote:

On Thu, 2017-08-03 at 13:08 -0700, Curtis Malainey wrote:

...

Minor debugging issue, when verbose trace is turned on it will not

compile

...

because these variables are incorrect.

src/audio/eq_fir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index ae87f92..41c6d38 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -323,9 +323,9 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd,

void *data)

...

                  fir_update, PLATFORM_MAX_CHANNELS);

          /* Print trace information */

•         tracev_value(iir_update->stream_max_channels);
  

•         tracev_value(fir_update->stream_max_channels);
          for (i = 0; i < fir_update->stream_max_channels; i++)
  

•                 tracev_value(iir_update->assign_response[i]);
  

•                 tracev_value(fir_update->assign_response[i]);
  
          break;
  case COMP_CMD_EQ_FIR_CONFIG:
  

Can I add your Signed-off-by to both these patches ?

Thanks

Liam

---

Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.