[Sound-open-firmware] Backport of SOF driver to 5.2.9 fixes
Hi SOF folks,
I've been able to address the issue I was seeing with 5.2.9 kernel and the SOF driver on our whiskeylake based system but would really appreciate a quick review from the experts to confirm that I've not missed anything important or add any extra insight.
The problem was seen on boot - the driver suspends and resumes a couple of times during boot and during the second resume failed to load the firmware (err -110). After that point the driver, and hence the audio, isn't useable.
I backported these commits to address the problem: https://github.com/thesofproject/linux/commit/bf705eaa7ce07f9c132f8e367fc2fc... https://github.com/thesofproject/linux/commit/64632de9140e52b72781fefe542314... https://github.com/thesofproject/linux/commit/7623ae793c28cc0928c5d1292542db... https://github.com/thesofproject/linux/commit/f5dbba9fee801f4678a50d92c785f7... https://github.com/thesofproject/linux/commit/bb1ea3b31c28a131a5f5a50dd32519...
We're still doing some testing to get confidence the fix is correct and stable but so far it looks good - everything is working.
Thanks Mark
On Wed, 2019-09-18 at 14:55 +0000, Mark Pearson wrote:
Hi SOF folks,
I've been able to address the issue I was seeing with 5.2.9 kernel and the SOF driver on our whiskeylake based system but would really appreciate a quick review from the experts to confirm that I've not missed anything important or add any extra insight.
The problem was seen on boot - the driver suspends and resumes a couple of times during boot and during the second resume failed to load the firmware (err -110). After that point the driver, and hence the audio, isn't useable.
I backported these commits to address the problem: https://github.com/thesofproject/linux/commit/bf705eaa7ce07f9c132f8e367fc2fc... https://github.com/thesofproject/linux/commit/64632de9140e52b72781fefe542314... https://github.com/thesofproject/linux/commit/7623ae793c28cc0928c5d1292542db... https://github.com/thesofproject/linux/commit/f5dbba9fee801f4678a50d92c785f7... https://github.com/thesofproject/linux/commit/bb1ea3b31c28a131a5f5a50dd32519...
We're still doing some testing to get confidence the fix is correct and stable but so far it looks good - everything is working.
These all look fine to me (all related to HDA, DMA or DAI), but best for Ranjani to comment if you need any more.
Thanks
Liam
Thanks Mark _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
On Wed, 2019-09-18 at 14:55 +0000, Mark Pearson wrote:
Hi SOF folks,
I've been able to address the issue I was seeing with 5.2.9 kernel and the SOF driver on our whiskeylake based system but would really appreciate a quick review from the experts to confirm that I've not missed anything important or add any extra insight.
The problem was seen on boot - the driver suspends and resumes a couple of times during boot and during the second resume failed to load the firmware (err -110). After that point the driver, and hence the audio, isn't useable.
I backported these commits to address the problem:
https://github.com/thesofproject/linux/commit/bf705eaa7ce07f9c132f8e367fc2fc...
https://github.com/thesofproject/linux/commit/64632de9140e52b72781fefe542314...
https://github.com/thesofproject/linux/commit/7623ae793c28cc0928c5d1292542db...
https://github.com/thesofproject/linux/commit/f5dbba9fee801f4678a50d92c785f7...
https://github.com/thesofproject/linux/commit/bb1ea3b31c28a131a5f5a50dd32519...
We're still doing some testing to get confidence the fix is correct and stable but so far it looks good - everything is working.
Hi Mark, All of the above changes are related to the HDA Link DMA programming changes that were made a few months ago. These changes work only with FW ABI version 3.8+.
I'd also take these as they were part of the original series and a couple of bug fixes later on:
ASoC: SOF: hda: reserve host DMA channel for hostless streams ASoC: SOF: hda: couple host and link DMA during FE hw_free ASoC: SOF: hda: fix link DMA config ASoC: SOF: hda: fix stream id setting
Thanks, Ranjani
Thanks Mark _______________________________________________ Sound-open-firmware mailing list Sound-open-firmware@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
I backported these commits to address the problem:
https://github.com/thesofproject/linux/commit/bf705eaa7ce07f9c132f8e36 7fc2fc46b7842528#diff-cea2d94f890861b7634fd37c0b28f5e1
https://github.com/thesofproject/linux/commit/64632de9140e52b72781fefe 542314db7cd29d8c#diff-cea2d94f890861b7634fd37c0b28f5e1
https://github.com/thesofproject/linux/commit/7623ae793c28cc0928c5d129 2542dbb92fc2e9e2#diff-8f8468b53f48ad4bb215687e90b21d04
https://github.com/thesofproject/linux/commit/f5dbba9fee801f4678a50d92 c785f7f24d4ee2c6#diff-8f8468b53f48ad4bb215687e90b21d04
https://github.com/thesofproject/linux/commit/bb1ea3b31c28a131a5f5a50d d325198645526b19#diff-cea2d94f890861b7634fd37c0b28f5e1
We're still doing some testing to get confidence the fix is correct and stable but so far it looks good - everything is working.
Hi Mark, All of the above changes are related to the HDA Link DMA programming changes that were made a few months ago. These changes work only with FW ABI version 3.8+.
I'd also take these as they were part of the original series and a couple of bug fixes later on:
ASoC: SOF: hda: reserve host DMA channel for hostless streams ASoC: SOF: hda: couple host and link DMA during FE hw_free ASoC: SOF: hda: fix link DMA config ASoC: SOF: hda: fix stream id setting
Thanks Ranjani! I'll definitely go and look at those. I think I'd identified them as potential candidates and then when everything worked I'd been hesitant to pull in more changes :) I really appreciate you taking the time to do the review. Thank you Mark
participants (3)
-
Liam Girdwood
-
Mark Pearson
-
Ranjani Sridharan