On 02/09/2025 11:32, Colin Ian King wrote:

Currently the error check from the call to sof_ipc4_get_sample_type is always false because a u32 variable out_ref_type is being used to perform the less than zero check. Fix this by using the int variable ret to perform the check.

Fixes: c04c2e829649 ("ASoC: SOF: ipc4-topology: Add support for 8-bit formats") Signed-off-by: Colin Ian King colin.i.king@gmail.com

Acked-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com

---

sound/soc/sof/ipc4-topology.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index f5e62cd8fc0c..b6a732d0adb4 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -2191,9 +2191,10 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget, case snd_soc_dapm_dai_in: out_ref_rate = params_rate(fe_params); out_ref_channels = params_channels(fe_params);

• out_ref_type = sof_ipc4_get_sample_type(sdev, fe_params);
  

• if (out_ref_type < 0)
  

• 	return out_ref_type;
  

• ret = sof_ipc4_get_sample_type(sdev, fe_params);
  

• if (ret < 0)
  

• 	return ret;
  

• out_ref_type = (u32)ret;
  
  

  if (!single_output_bitdepth) { out_ref_valid_bits = sof_ipc4_get_valid_bits(sdev, fe_params);