On 5/13/2024 7:37 PM, Christophe JAILLET wrote:

snd_soc_tplg_component_load() does not modify its "*ops" argument. It only read some values and stores it in "soc_tplg.ops".

This argument and the ops field in "struct soc_tplg" can be made const.

Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr

include/sound/soc-topology.h | 2 +- sound/soc/soc-topology.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/sound/soc-topology.h b/include/sound/soc-topology.h index f055c6917f6c..1eedd203ac29 100644 --- a/include/sound/soc-topology.h +++ b/include/sound/soc-topology.h @@ -178,7 +178,7 @@ static inline const void *snd_soc_tplg_get_data(struct snd_soc_tplg_hdr *hdr)

/* Dynamic Object loading and removal for component drivers */ int snd_soc_tplg_component_load(struct snd_soc_component *comp,

• struct snd_soc_tplg_ops *ops, const struct firmware *fw);

• const struct snd_soc_tplg_ops *ops, const struct firmware *fw); int snd_soc_tplg_component_remove(struct snd_soc_component *comp);

  /* Binds event handlers to dynamic widgets */

diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 90ca37e008b3..b00ec01361c2 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -73,7 +73,7 @@ struct soc_tplg { int bytes_ext_ops_count;

/* optional fw loading callbacks to component drivers */

• struct snd_soc_tplg_ops *ops;

• const struct snd_soc_tplg_ops *ops; };

  /* check we dont overflow the data for this control chunk */

@@ -2334,7 +2334,7 @@ static int soc_tplg_load(struct soc_tplg *tplg)

/* load audio component topology from "firmware" file */ int snd_soc_tplg_component_load(struct snd_soc_component *comp,

• struct snd_soc_tplg_ops *ops, const struct firmware *fw)

• const struct snd_soc_tplg_ops *ops, const struct firmware *fw) { struct soc_tplg tplg; int ret;

Yes, makes sense to me.

Reviewed-by: Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com